2604 location accuracy #2641
2604 location accuracy #2641
Conversation
ziv17
force-pushed
the
2604-location-accuracy
branch
3 times, most recently
from
418fdad to
76850b8
Compare
anyway/widgets/all_locations_widgets/killed_and_injured_count_per_age_group_widget_utils.py
Outdated
Show resolved
Hide resolved
|
@ziv17 can you prod merge dev into this branch? I want to examine in the pr only the relevant changes for this issue |
Add resolution parameter to get_accidents_stats() to add the location accuracy filter. In widgets that do not use it, handle the filter dicts that is passed to get_quary, or the filter directly.
ziv17
force-pushed
the
2604-location-accuracy
branch
from
76850b8 to
fef1db0
Compare
I rebased on top of upstream/dev. |
There was a problem hiding this comment.
@ziv17 great work! All in all the PR looks good!
I wonder if there is a need to add location_accuracy as index for the CBS View tables.
I think the answer is no for now, since it's always queried with other location variables that are indexed.
However, if we see that this change impacts the running time of the cache update flows, we'll reconsider.
Hence the only thing left to change is the BackEnd Consts comment, and then I'll merge.
Great work! Thanks!
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #2641 +/- ##
==========================================
+ Coverage 53.22% 53.52% +0.30%
==========================================
Files 119 119
Lines 9924 9956 +32
==========================================
+ Hits 5282 5329 +47
+ Misses 4642 4627 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Add location accuracy filter according to the current resolution.
The addition is made in get_accidents_stats where possible.