Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tags for news flashes #1091

Open
Mano3 opened this issue Jan 20, 2020 · 8 comments · May be fixed by #1129
Open

Create tags for news flashes #1091

Mano3 opened this issue Jan 20, 2020 · 8 comments · May be fixed by #1129

Comments

@Mano3
Copy link
Collaborator

Mano3 commented Jan 20, 2020

for example in the following news flash:
"תאונת קורקינט באבן גבירול"
קורקינט could be a tag,
so a method to detect and create a list of tags for a news flash is needed, including a creation of a tags list column to the news flash table

@sagivharel
Copy link
Collaborator

אני אעשה את זה

@sagivharel
Copy link
Collaborator

Do we want to decide on a fix set of tags topics like type of involved automobile, accident's severance etc. and build the function as an extractor of tags (similar to our accident's classification methods) or do you think it should be somehow "smarter" (maybe based on POS)

@Mano3
Copy link
Collaborator Author

Mano3 commented Feb 2, 2020

There is no working NER in Hebrew, especially not for our domain, and training one would be an overkill (and we don't have enough labeled data).
Smart fixed set is the best (open to extensions and considers lemmatizing and declensions)

@atalyaalon
Copy link
Collaborator

@sagivharel @Mano3 please create a basic list of tags, and let's discuss it

@Mano3 Mano3 self-assigned this Mar 6, 2020
@atalyaalon atalyaalon added this to the NewsFlash-M1 milestone Mar 15, 2020
@atalyaalon
Copy link
Collaborator

@sagivharel @Mano3 any progress on this one?

@Mano3
Copy link
Collaborator Author

Mano3 commented Apr 6, 2020

@sagivharel @Mano3 any progress on this one?

None that I know of, Could you contact Sagiv?

@atalyaalon atalyaalon assigned advak and unassigned Mano3 and sagivharel May 11, 2020
@atalyaalon
Copy link
Collaborator

atalyaalon commented May 11, 2020

@advak most of this issue is done (see this PR), but there is still some code needed to complete it. Can you take it? (We can discuss it offline if you have any questions)

@atalyaalon
Copy link
Collaborator

atalyaalon commented Jun 5, 2020

@Mano3 I will take this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment