Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Floating label not changing direction #704

Closed
daniel-ilan opened this issue Jul 10, 2021 · 2 comments · Fixed by #740
Closed

[Refactor] Floating label not changing direction #704

daniel-ilan opened this issue Jul 10, 2021 · 2 comments · Fixed by #740
Assignees
@EyalIlan
Labels
blocked Priority 2 Priority 2
Milestone
v0.16.0

Comments

@daniel-ilan
Copy link
Collaborator

daniel-ilan commented Jul 10, 2021 •
edited by yuvalbl
Loading

Blocked by #843

  1. Go to home page
  2. Log in
  3. Click "פרטי משתמש" while on Hebrew language
  • see the floating label is floating on the top left side of the input - it should change direction to the right

image
@daniel-ilan
Copy link
Collaborator Author

From what I can tell we are missing a metirial-ui dependency when changing direction.
According to their documentation we should install jss-rtl plugin and initiate it after the theme

Also see this stack-overflow discussion about the same

@yuvalbl yuvalbl added good first issue Good for newcomers Priority 2 Priority 2 labels Jul 14, 2021
@yuvalbl yuvalbl added this to the v0.7.0 milestone Jul 14, 2021
@EyalIlan EyalIlan assigned EyalIlan and unassigned YaronAvraham93 Jul 21, 2021
@yuvalbl yuvalbl modified the milestones: v0.7.0, v0.8.0 Aug 4, 2021
@EyalIlan EyalIlan mentioned this issue Aug 9, 2021
Merged
@yuvalbl yuvalbl modified the milestones: v0.8.0, v0.9.0 Sep 14, 2021
@yuvalbl yuvalbl mentioned this issue Oct 13, 2021
Open
@yuvalbl yuvalbl reopened this Oct 13, 2021
@yuvalbl
Copy link
Collaborator

yuvalbl commented Oct 13, 2021

Reopened - see my comment on #740
will be postponed till after we upgrade to MUI (v5) - #790

@yuvalbl yuvalbl added blocked and removed good first issue Good for newcomers labels Oct 13, 2021
@yuvalbl yuvalbl modified the milestones: v0.9.0, v0.12.0 Oct 13, 2021
@yuvalbl yuvalbl modified the milestones: v0.12.0, v0.14.0 Dec 29, 2021
@danielsh28 danielsh28 modified the milestones: v0.14.0, v0.15.0 Feb 16, 2022
@danielsh28 danielsh28 modified the milestones: v0.15.0, v0.16.0 Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EyalIlan EyalIlan

Labels
blocked Priority 2 Priority 2
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging a pull request may close this issue.

adding rtl theme data-for-change/anyway-newsflash-infographics
5 participants
@yuvalbl @danielsh28 @daniel-ilan @EyalIlan @YaronAvraham93