Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Map - Concatenate date labels in FE for near or exact-location accidents #648 #1117

Closed
atalyaalon opened this issue Jun 22, 2024 · 1 comment · Fixed by #1120
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@atalyaalon
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Widget Name: most_severe_accidents

Currently, accidents can overlap if they are close to each other or have the same GPS location (as shown in the Screen shot). It's impossible to know how many accidents are overlapping and move their labels so at least the labels are not overlapping (simply because you can't select the accident that is not on top).
ANYWAY

For example: in this location in widget most_severe_accidents there are 6 accidents in the exact same location with the exact same GPS, but we only see some of the dates instead of all of the dates on the map.

Screenshot 2024-06-22 at 17 33 31

What should be done:
In FE - in case accidents are in the exact same location or close enough - "join" them to one accident icon (not a "flower" cluster like we see in anyway but one single icon), and consolidate all dates into one label with all dates presented next to the accident icon.
Regarding icon color: I suggest the icon color will be by the most severe accident - fatal if fatal otherwise severe , and later we'll create a unique icon that combines both if both fatal and severe are at the same "joint" location.
@galraij can you take care of a joint icon of both severe and fatal accidents (both red and orange)?

Another option which is less preferable if the above suggestion is problematic: It can be done with "flower" version, just like ANYWAY map and like we considered in the past BUT only if the labels with dates are always visible - meaning flower is always open.
If we're using the "flower" version (in which many icons are tied with lines to one point on the map) have the dates presented next to each icon in a readable way.

@atalyaalon atalyaalon added the enhancement New feature or request label Jun 22, 2024
@atalyaalon atalyaalon added this to the v0.17.0 milestone Jun 22, 2024
@atalyaalon atalyaalon assigned danielsh28 and unassigned aviklai Jul 23, 2024
@atalyaalon atalyaalon linked a pull request Sep 7, 2024 that will close this issue
@atalyaalon
Copy link
Contributor Author

@danielsh28 great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants