Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Error needs to be emitted if replication connections destroy with a failure #17

Open
pfrazee opened this issue Dec 28, 2016 · 1 comment
Open

Error needs to be emitted if replication connections destroy with a failure #17

pfrazee opened this issue Dec 28, 2016 · 1 comment
Labels
fix
Milestone
v1

Comments

@pfrazee
Copy link
Collaborator

pfrazee commented Dec 28, 2016

Quite related to #16

Turns out there are some conditions occurring which cause replication feeds to stop with an error. Replication streams should end with an error when that happens. Where-ever the replication stream is created, we need to be sure there's code listening for its end and emitting the error in the non-debug logs.

cc @mafintosh
@pfrazee
Copy link
Collaborator Author

pfrazee commented Dec 30, 2016

Looks like the best way to do this is to attach to the 'error' event on hypercore-protocol instances

@pfrazee pfrazee added fix and removed enhancement labels Dec 31, 2016
@pfrazee pfrazee modified the milestone: v1 Dec 31, 2016
garbados pushed a commit to garbados/hypercloud that referenced this issue Aug 14, 2017
@timmak
Fixes dat-ecosystem-archive#17
144ecf8 
Fixing the link for install beaker
garbados pushed a commit to garbados/hypercloud that referenced this issue Aug 14, 2017
@pfrazee
Merge pull request dat-ecosystem-archive#18 from timmak/patch-1
22aa80e 
Fixes dat-ecosystem-archive#17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
v1
Development

No branches or pull requests
1 participant
@pfrazee