From 41c37a8d60bf34fee01175f07b71f7ebe5dfa22e Mon Sep 17 00:00:00 2001 From: Marcin Procyk Date: Mon, 6 Nov 2023 11:22:56 +0100 Subject: [PATCH 1/4] add perf to changelog list --- .github/workflows/create-release.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/create-release.yml b/.github/workflows/create-release.yml index 82e0cbd18c..0185a98859 100644 --- a/.github/workflows/create-release.yml +++ b/.github/workflows/create-release.yml @@ -20,11 +20,12 @@ jobs: package-name: dsp-api pull-request-title-pattern: "chore${scope}: Release${component} ${version}" changelog-types: '[ - {"type": "feat", "section": "Enhancements", "hidden": false }, - {"type": "fix", "section": "Bug Fixes", "hidden": false }, {"type": "build", "section": "Maintenance", "hidden": false }, {"type": "chore", "section": "Maintenance", "hidden": false }, - {"type": "test", "section": "Maintenance", "hidden": false }, + {"type": "docs", "section": "Documentation", "hidden": false }, + {"type": "feat", "section": "Enhancements", "hidden": false }, + {"type": "fix", "section": "Bug Fixes", "hidden": false }, + {"type": "perf", "section": "Maintenance", "hidden": false }, {"type": "refactor", "section": "Maintenance", "hidden": false }, - {"type": "docs", "section": "Documentation", "hidden": false } + {"type": "test", "section": "Maintenance", "hidden": false } ]' From f77fb840e0a1fa651de25445f388bc7ba2b8c38f Mon Sep 17 00:00:00 2001 From: Marcin Procyk Date: Mon, 6 Nov 2023 11:24:20 +0100 Subject: [PATCH 2/4] add build to PR template Signed-off-by: Marcin Procyk --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ca7de80187..5755151963 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -10,7 +10,7 @@ Issue Number: DEV- ### PR Type -- [ ] chore: maintenance tasks (no production code change) +- [ ] build/chore: maintenance tasks (no production code change) - [ ] docs: documentation changes (no production code change) - [ ] feat: represents a new feature - [ ] fix: represents bug fixes From f16144465bfc4cc196cab59222739df9845d125d Mon Sep 17 00:00:00 2001 From: Marcin Procyk Date: Mon, 6 Nov 2023 11:28:17 +0100 Subject: [PATCH 3/4] PR template cleanup --- .github/pull_request_template.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 5755151963..e051bdd1db 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -12,13 +12,13 @@ Issue Number: DEV- - [ ] build/chore: maintenance tasks (no production code change) - [ ] docs: documentation changes (no production code change) -- [ ] feat: represents a new feature +- [ ] feat: represents new features - [ ] fix: represents bug fixes - [ ] perf: performance improvements - [ ] refactor: represents production code refactoring -- [ ] test: all about tests: adding, refactoring tests (no production code change) +- [ ] test: adding or refactoring tests (no production code change) -### Basic Requirements for bug fixes and features +### Basic requirements for bug fixes and features - [ ] Tests for the changes have been added - [ ] Docs have been added / updated From 2b47e7bb5ca19388c5d8cfbbc7421d2b59bb6c2f Mon Sep 17 00:00:00 2001 From: Marcin Procyk Date: Tue, 7 Nov 2023 10:11:11 +0100 Subject: [PATCH 4/4] move perf prefix to Enhancements section --- .github/workflows/create-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/create-release.yml b/.github/workflows/create-release.yml index 0185a98859..0cf439772e 100644 --- a/.github/workflows/create-release.yml +++ b/.github/workflows/create-release.yml @@ -25,7 +25,7 @@ jobs: {"type": "docs", "section": "Documentation", "hidden": false }, {"type": "feat", "section": "Enhancements", "hidden": false }, {"type": "fix", "section": "Bug Fixes", "hidden": false }, - {"type": "perf", "section": "Maintenance", "hidden": false }, + {"type": "perf", "section": "Enhancements", "hidden": false }, {"type": "refactor", "section": "Maintenance", "hidden": false }, {"type": "test", "section": "Maintenance", "hidden": false } ]'