From 63d1a1e158f41b73cc64161b98d22e920d4a8b97 Mon Sep 17 00:00:00 2001 From: Marcin Procyk Date: Thu, 12 Oct 2023 12:39:16 +0200 Subject: [PATCH 1/2] update PR template --- .github/pull_request_template.md | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 52d0459d8c..55828eee6c 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -10,15 +10,11 @@ Issue Number: DEV- ### Basic Requirements -Please check if your PR fulfills the following requirements: - - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) ### PR Type -What kind of change does this PR introduce? - - [ ] fix: represents bug fixes - [ ] refactor: represents production code refactoring - [ ] feat: represents a new feature @@ -32,10 +28,7 @@ What kind of change does this PR introduce? - [ ] Yes -- [ ] No -- [ ] Maybe (not 100% sure => check with FE) ### Does this PR change client-test-data? -- [ ] Yes (don't forget to update the JS-LIB team about the change) -- [ ] No +- [ ] Yes From 4af2ac9f6251f7a3f0eba33d31e63a2390258dce Mon Sep 17 00:00:00 2001 From: Marcin Procyk Date: Thu, 12 Oct 2023 12:44:21 +0200 Subject: [PATCH 2/2] reorganize --- .github/pull_request_template.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 55828eee6c..c5bbd074ed 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,11 +8,6 @@ Issue Number: DEV- -### Basic Requirements - -- [ ] Tests for the changes have been added (for bug fixes / features) -- [ ] Docs have been added / updated (for bug fixes / features) - ### PR Type - [ ] fix: represents bug fixes @@ -23,6 +18,11 @@ Issue Number: DEV- - [ ] test: all about tests: adding, refactoring tests (no production code change) - [ ] other... Please describe: +### Basic Requirements for bug fixes and features + +- [ ] Tests for the changes have been added +- [ ] Docs have been added / updated + ### Does this PR introduce a breaking change?