Created estop #10
Open
Created estop #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hardikparwana tested, it works. Ready to merge. |
|
@hardikparwana can you confirm whether this is ready to be merged in? |
|
It takes a few moment for the ROS2 node discovery and connect to the drone node. Therefore I think we can spin it at background and have it setup the connection between each drone and wait for a user input to trigger the estop command. |
chenrc98
reviewed
Sep 28, 2022
|
|
||
| rclcpp::init(argc, argv); | ||
|
|
||
| rclcpp::spin(std::make_shared<Estop>()); |
There was a problem hiding this comment.
change to
auto estop_node = std::make_shared<Estop>();
rclcpp::executors::MultiThreadedExecutor server_exec;
server_exec.add_node(estop_node);
auto server_spin_exec = [&server_exec]() {
server_exec.spin();
};
There was a problem hiding this comment.
ok good idea, ill make these changes, but we should wait only merge them after weve tested to see that it works.
| timer_ = this->create_wall_timer( | ||
| 200ms, std::bind(&Estop::timer_callback, this)); | ||
| } | ||
|
|
| } | ||
|
|
||
| private: | ||
|
|
| rclcpp::init(argc, argv); | ||
|
|
||
| rclcpp::spin(std::make_shared<Estop>()); | ||
|
|
There was a problem hiding this comment.
Block by
int n;
std::cin >> n;
estop_node.estop();
while(rclcpp::ok()) {
std::this_thread::sleep_for(std::chrono::milliseconds(50));
}
There was a problem hiding this comment.
ok we can do something like this. are you sure the std::cin trick works in multithreaded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.