[frontend_server] Deprecate moduleName from compile-expression-to-js
#58265
Labels
area-web
Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop.
front-end-server
Issues with the frontend server
type-task
A well-defined stand-alone task
web-dev-compiler
Comments
copybara-service bot
pushed a commit
that referenced
this issue
Nov 20, 2024
#58265 The DDC library bundle format does not give names to modules. Therefore the frontend server should try and find the compiler associated with the library and not the module to be consistent. This then means that moduleName becomes entirely unused, and therefore we can soft-deprecate it. Change-Id: I241c63a346d046405599384409a373ab12be2654 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396102 Commit-Queue: Srujan Gaddam <[email protected]> Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot
pushed a commit
that referenced
this issue
Nov 21, 2024
…sionToJS" This reverts commit 294a50f. Reason for revert: This breaks `frontend_server_circular_evaluate_test` in DWDS. Original change's description: > [frontend_server] Soft-deprecate moduleName for compileExpressionToJS > > #58265 > > The DDC library bundle format does not give names to modules. > Therefore the frontend server should try and find the compiler > associated with the library and not the module to be consistent. > This then means that moduleName becomes entirely unused, and > therefore we can soft-deprecate it. > > Change-Id: I241c63a346d046405599384409a373ab12be2654 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396102 > Commit-Queue: Srujan Gaddam <[email protected]> > Reviewed-by: Johnni Winther <[email protected]> Change-Id: I74b096f7ebc322c9d4428d236ab226ef1adcb6b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396567 Reviewed-by: Nicholas Shahan <[email protected]> Reviewed-by: Johnni Winther <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Srujan Gaddam <[email protected]>
lrhn
added
type-task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
moduleNameis only ever used in one place - to cache the DDC program compiler so that it can be reused for expression evaluation:sdk/pkg/frontend_server/lib/src/javascript_bundle.dart
Line 234 in 6dac184
sdk/pkg/frontend_server/lib/frontend_server.dart
Line 1128 in 6dac184
moduleNamecan be deprecated from the request. Removing it would be a breaking change, however.The text was updated successfully, but these errors were encountered: