Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DTD interface #55998

Closed
CoderDake opened this issue Jun 13, 2024 · 2 comments
Closed

Improve DTD interface #55998

CoderDake opened this issue Jun 13, 2024 · 2 comments
Assignees
@DanTup
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. dart-cli-tooling-daemon Issues related to the 'dart tooling-daemon' tool P3 A lower priority bug or feature request pkg-dtd For issues related to the Dart Tooling Daemon (package:dtd or pkg/dtd_impl within the Dart SDK) type-enhancement A request for a change that isn't a bug

Comments

@CoderDake
Copy link

  • Danny's comments:
    • Should be able to provide Streams instead of just a Uri to DartToolingDaemon, so we can provide our own streams (good for testing, or for injecting logging of traffic)
    • Should be able to subclass (currently has private constructor so cannot).. This would be another way to provide some logging of calls in/out or changing behaviour in tests etc

Potential resolution:
Make the constructor public
@DanTup @bkonyi
@CoderDake CoderDake added P3 A lower priority bug or feature request dart-cli-tooling-daemon Issues related to the 'dart tooling-daemon' tool labels Jun 13, 2024
@dart-github-bot
Copy link
Collaborator

area-web, type-enhancement

The DTD interface currently limits users to providing URIs, preventing them from injecting custom streams for testing or logging. Additionally, the private constructor prevents subclassing, hindering the ability to customize behavior or add logging in tests.

@dart-github-bot dart-github-bot added area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-enhancement A request for a change that isn't a bug labels Jun 13, 2024
@devoncarew devoncarew added area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. and removed area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. labels Jun 13, 2024
@DanTup DanTup self-assigned this Jun 17, 2024
@DanTup
Copy link
Collaborator

DanTup commented Jun 20, 2024

I have a change in progress for this at https://dart-review.googlesource.com/c/sdk/+/371900

@kenzieschmoll kenzieschmoll added the pkg-dtd For issues related to the Dart Tooling Daemon (package:dtd or pkg/dtd_impl within the Dart SDK) label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanTup DanTup

Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. dart-cli-tooling-daemon Issues related to the 'dart tooling-daemon' tool P3 A lower priority bug or feature request pkg-dtd For issues related to the Dart Tooling Daemon (package:dtd or pkg/dtd_impl within the Dart SDK) type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@DanTup @devoncarew @CoderDake @kenzieschmoll @dart-github-bot