Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent generating and delete generated file on any [SEVERE] Errors #439

Closed
dcharkes opened this issue Nov 8, 2023 · 2 comments · Fixed by #810
Closed

Prevent generating and delete generated file on any [SEVERE] Errors #439

dcharkes opened this issue Nov 8, 2023 · 2 comments · Fixed by #810
Labels
package:ffigen

Comments

@dcharkes
Copy link
Collaborator

dcharkes commented Nov 8, 2023

FFIgen can output a lot of logs, which leads people to ignore them and subsequently file issues that the generated code is broken.

Instead, we should refuse to generate code (and delete the existing generated file if one already exists) so that users stop ignoring [SEVERE] errors.

Latest instance:

@mannprerak2 Would you mind making a PR for this?
@mannprerak2
Copy link
Contributor

Sure @dcharkes , I'll try by the weekend 😃

Or do you think maybe we should wait #185 first?

@dcharkes
Copy link
Collaborator Author

dcharkes commented Nov 8, 2023

Or do you think maybe we should wait dart-lang/native#185 first?

cc @liamappelbe

@liamappelbe liamappelbe transferred this issue from dart-archive/ffigen Nov 15, 2023
@dcharkes dcharkes mentioned this issue Nov 8, 2023
Closed
@mannprerak2 mannprerak2 mentioned this issue Nov 18, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:ffigen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ffigen] Add config ignore-source-errors mannprerak2/native
2 participants
@dcharkes @mannprerak2