Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont let user set as FR special ethereum address #2037

Open
Marketen opened this issue Sep 23, 2024 · 0 comments
Open

Dont let user set as FR special ethereum address #2037

Marketen opened this issue Sep 23, 2024 · 0 comments
Labels
P2 Worth doing eventually, no rush

Comments

@Marketen
Copy link
Contributor

Marketen commented Sep 23, 2024

We let user add as default FR 0x1000000000000000000000000000000000000000, but it is in fact another burn address, just like 0x0000...0000. We should not let user use this FR.
image

Consensus client lighthouse defaults to burn address when FR 0x1000...0000 is set and prints a warning. This could cause trouble like crashes in the future, if consensus clients are more strict about this:

[WARN - entrypoint] Fee recipient address is invalid. It should be an Ethereum address
[WARN - entrypoint] Setting the fee recipient address to the burn address
@Marketen Marketen added the P2 Worth doing eventually, no rush label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Worth doing eventually, no rush
Projects
None yet
Development

No branches or pull requests

1 participant