New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not block `packageInstall` if `exposeDefaultPorts` and/or `connectToPublicNetwork` fails #1995

Open

pablomendezroyo opened this issue Jul 16, 2024 · 0 comments

Contributor

pablomendezroyo commented Jul 16, 2024

Review the logic behind

connectToPublicNetwork : see

DNP_DAPPMANAGER/packages/installer/src/installer/runPackages.ts

Line 102 in 680afa4

await httpsPortal.connectToPublicNetwork(pkg, externalNetworkName);
exposeByDefaultHttpsPorts: see

DNP_DAPPMANAGER/packages/installer/src/installer/runPackages.ts

Line 103 in 680afa4

await httpsPortal.exposeByDefaultHttpsPorts(pkg, log);

And bypass on error

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment