From 2219e9989de89a1f4b8017eb772e96417a0177af Mon Sep 17 00:00:00 2001 From: pablomendezroyo <41727368+pablomendezroyo@users.noreply.github.com> Date: Mon, 22 Jul 2024 17:35:22 +0200 Subject: [PATCH] Do not install exporter pkg if ethical metrics enabled (#1997) Do not install exporter pkg if ethical metrics enabled --- .../ethicalMetrics/checkEthicalMetricsStatus.ts | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/packages/daemons/src/ethicalMetrics/checkEthicalMetricsStatus.ts b/packages/daemons/src/ethicalMetrics/checkEthicalMetricsStatus.ts index bb68ce5b7..6b2234de1 100644 --- a/packages/daemons/src/ethicalMetrics/checkEthicalMetricsStatus.ts +++ b/packages/daemons/src/ethicalMetrics/checkEthicalMetricsStatus.ts @@ -7,12 +7,11 @@ import { InstalledPackageData } from "@dappnode/types"; /** * Make sure that on Ethical metrics enabled and existing email, - * the packages exporter, DMS and Ethical metrics are installed and running + * the packages DMS and Ethical metrics are installed and running */ export async function checkEthicalMetricsStatus( dappnodeInstaller: DappnodeInstaller ): Promise { - const exporterDnpName = "dappnode-exporter.dnp.dappnode.eth"; const dmsDnpName = "dms.dnp.dappnode.eth"; try { @@ -22,9 +21,8 @@ export async function checkEthicalMetricsStatus( if (enabled) { if (!mail && !tgChannelId) throw Error("mail or tgChannelId is required"); - // First check for Ethical metrics, then for DMS and last for Exporter + // First check for Ethical metrics, then for DMS // Ethical Metrics package has DMS as dependency, so it will be installed automatically - // DMS package has Exporter as dependency, so it will be installed automatically // Check ethical metrics pkg const ethicalMetricsPkg = await listPackageNoThrow({ @@ -42,14 +40,6 @@ export async function checkEthicalMetricsStatus( await packageInstall(dappnodeInstaller, { name: dmsDnpName }); else ensureAllContainersRunning(dmsPkg); - // check exporter pkg - const exporterPkg = await listPackageNoThrow({ - dnpName: exporterDnpName, - }); - if (!exporterPkg) - await packageInstall(dappnodeInstaller, { name: exporterDnpName }); - else ensureAllContainersRunning(exporterPkg); - // Register instance await register({ mail, tgChannelId }); }