-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kde: fix plasma cli tools in activation #547
base: master
Are you sure you want to change the base?
Conversation
@danth is there anything to change or is this fit for merge? |
Hello @trueNAHO, I looked at other PRs and saw you were quite active. Is there anything more to do? I saw the push for decoupling wallpaper from other settings, but I would rather fix this before going into more refactoring. |
Unfortunately, I am unfamiliar with the KDE internals and what exactly is required on the Nix level. Consider waiting on @danth's review or pinging anyone who last touched the KDE module.
What push are you referring to?
I agree that it would be good to merge this PR prior to further refactoring. |
Roadmap in #534 lists support for multiple and/or optional wallpaper as goals for future. |
@danth is there anything I should change? |
@rkuklik This unfortunately does not always work. On my system, waiting for Besides the improper timing, the service does however work wonderfully, amazing work~ I'm new to |
Thank you for review. For me, |
Hm, I just realized that waiting for Maybe you can run this using some KDE Plasma mechanic, like autostart? Create a "hidden" .desktop file and have it run the missing stylix bits? |
Agreed, I do not think what worked on my system works on all systems by any means. I am new to NixOS and Linux in general, but is there a way to programmatically start the service on the condition that the background services fails? |
Disabled stylix for KDE Plasma 6, see danth/stylix#547 Updated the documentation
I finally got around to implement this, using what Plasma calls an "AutostartScript". It's basically a desktop entry in the autostart directory which has a special tag I hope that this should work for all scenarios since it doesn't depend on the activation method. @rkuklik @hiibolt Would you be willing to try out my change and see if it works for your setups too? |
KDE theming uses CLI tools which require D-Bus and Plasma session. Instead of breaking home-manager activation, this PR allows it to fail and introduces optional systemd unit to run after login.
Fixes #422, #350 and #340
Please note that the service (if enabled) is suboptimal, as it will continually restart even if not in KDE session. I am not good enough with systemd to fix this with confidence in my solution. Should be a non-issue though, given that it has to be explicitly enabled. Restarting is mandatory (in my opinion), because first activation fails with
The name is not activable
when loading wallpaper by idstylix
and I don't want to resort to hacks likesleep 5s && set-wallpaper
.