Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylix: simplify mkEnableTarget documentation #399

Conversation

trueNAHO
Copy link
Collaborator

@trueNAHO trueNAHO commented May 27, 2024

Simplify the stylix.mkEnableTarget documentation to simplify its documentation extension in #244.

Due to some targets not being enabled by default with stylix.mkEnableTarget, the documentation incorrectly generates Default: false in some cases with #399. Resolving this involves manually extending docs/settings.nix or enabling all targets by default with stylix.mkEnableTarget.

-- #400

Copy link
Contributor

@jalil-salame jalil-salame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't see the need for this if #398 is merged

@trueNAHO
Copy link
Collaborator Author

LGTM, but I don't see the need for this if #398 is merged

#398 replaces lib.mkOption with lib.mkEnableOption, while this PR makes defaultText optional. Both PRs cause merge conflicts, but address different aspects.

stylix/target.nix Outdated Show resolved Hide resolved
@danth
Copy link
Owner

danth commented Jun 1, 2024

This needs to be rebased since #398 was merged

Simplify the 'stylix.mkEnableTarget' documentation.

The following issue is to be resolved in
danth#400:

> Due to some targets not being enabled by default with
> 'stylix.mkEnableTarget', the documentation incorrectly generates
> 'Default: false' in some cases
@trueNAHO trueNAHO force-pushed the docs-stylix-target-simplify-mkenabletarget-documentation branch from 4da2d6f to 2557e07 Compare June 1, 2024 01:12
@trueNAHO trueNAHO requested a review from danth June 1, 2024 01:12
@danth danth merged commit 266db7f into danth:master Jun 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants