Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qutebrowser: use correct fonts.web.size.default type #239

Conversation

trueNAHO
Copy link
Collaborator

@trueNAHO trueNAHO commented Feb 1, 2024

Use the correct fonts.web.size.default type to avoid the following error:

Errors occurred while reading config.py:
While setting 'fonts.web.size.default': Invalid value '10pt' - expected a value of type int but got str.

Reference: https://qutebrowser.org/doc/help/settings.html#fonts.web.size.default
Follows: #221

Use the correct 'fonts.web.size.default' type to avoid the following
error:

> Errors occurred while reading config.py:
>   While setting 'fonts.web.size.default': Invalid value '10pt' -
>   expected a value of type int but got str.

Reference: https://qutebrowser.org/doc/help/settings.html#fonts.web.size.default
Follows: danth#221
@danth
Copy link
Owner

danth commented Feb 7, 2024

Note that the documentation says this size is measured in pixels, but our setting is in points. 1 point = 1.333 pixels

@trueNAHO
Copy link
Collaborator Author

trueNAHO commented Feb 7, 2024

Note that the documentation says this size is measured in pixels

Good catch! 197b81c addresses this.

our setting is in points. 1 point = 1.333 pixels

To reduce future maintainance work, we should provide sizes in both measures.

@danth danth merged commit 9942fca into danth:master Feb 7, 2024
5 checks passed
trueNAHO added a commit to trueNAHO/dotfiles that referenced this pull request Feb 9, 2024
Update the 'stylix' input primarily to receive the
danth/stylix#239 patch that resolves a
Qutebrowser error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants