Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modules/zathura): remove default recolor configurations #174

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

trueNAHO
Copy link
Collaborator

@trueNAHO trueNAHO commented Oct 18, 2023

Redeclaring the default recolor configurations does not alter the theme, but requires using lib.mkForce to modify the default configurations.

For reference, the zathurarc(5) man page states the following:

recolor
En/Disables recoloring

   • Value type: Boolean

   • Default value: false

recolor-keephue
En/Disables keeping original hue when recoloring

   • Value type: Boolean

   • Default value: false

Redeclaring the default recolor configurations does not alter the theme,
but requires using 'lib.mkForce' to modify the default configurations.

For reference, the 'zathurarc(5)' man page states the following:

> recolor
>        En/Disables recoloring
>
>        • Value type: Boolean
>
>        • Default value: false
>
> recolor-keephue
>        En/Disables keeping original hue when recoloring
>
>        • Value type: Boolean
>
>        • Default value: false
Copy link
Owner

@danth danth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. It looks as if this was originally meant to be true but was disabled for some reason.

@danth danth enabled auto-merge (squash) October 19, 2023 12:46
@danth danth merged commit 4c1acb8 into danth:master Oct 19, 2023
5 checks passed
trueNAHO added a commit to trueNAHO/dotfiles that referenced this pull request Oct 19, 2023
trueNAHO added a commit to trueNAHO/dotfiles that referenced this pull request Oct 19, 2023
@trueNAHO trueNAHO mentioned this pull request Jun 6, 2024
@trueNAHO trueNAHO mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants