Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDM not themed when Gnome is disabled #596

Closed
Kasper24 opened this issue Oct 16, 2024 · 1 comment · Fixed by #598
Closed

GDM not themed when Gnome is disabled #596

Kasper24 opened this issue Oct 16, 2024 · 1 comment · Fixed by #598
Labels
technical debt Things which should be cleaned up or improved

Comments

@Kasper24
Copy link
Contributor

This line is the reason why, I wonder if there's a need for it?

stylix/modules/gnome/nixos.nix

Line 15 in 33a2eff

&& config.services.xserver.desktopManager.gnome.enable

@trueNAHO
Copy link
Collaborator

This line is the reason why, I wonder if there's a need for it?

stylix/modules/gnome/nixos.nix

Line 15 in 33a2eff

&& config.services.xserver.desktopManager.gnome.enable

Since the introduction of this guard in commit 46899f2 ("Style GNOME shell ✨") the convention to enable Stylix modules has slightly changed.

Considering the discussions in #543 we may want to remove the config.services.xserver.desktopManager.gnome.enable guard.

Feel free to submit a PR.

@trueNAHO trueNAHO added the technical debt Things which should be cleaned up or improved label Oct 16, 2024
@trueNAHO trueNAHO mentioned this issue Oct 23, 2024
Merged
@danth danth linked a pull request Oct 26, 2024 that will close this issue
gnome: fix GDM theme not applying when Gnome is disabled #598
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt Things which should be cleaned up or improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gnome: fix GDM theme not applying when Gnome is disabled Kasper24/stylix
2 participants
@Kasper24 @trueNAHO