Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to choose a custom accent/primary color #550

Closed
vfosnar opened this issue Sep 9, 2024 · 4 comments
Closed

Ability to choose a custom accent/primary color #550

vfosnar opened this issue Sep 9, 2024 · 4 comments
Labels
technical debt Things which should be cleaned up or improved

Comments

@vfosnar
Copy link

vfosnar commented Sep 9, 2024

For example in GTK there is an option for an accent color, currently hardcoded to base0D. I would like to have an option like stylix.accent that will be used instead.

For example:

stylix.accent = config.lib.stylix.colors.base0C

I am willing to contribute code if I find the time to do so.

@trueNAHO
Copy link
Collaborator

trueNAHO commented Sep 9, 2024

This is an already acknowledged problem:

the use of extraConfig might cause other potentially related issues. As discussed in #159 (comment), it makes it harder to override options, and as discussed in #388 (comment), it makes it easier to accidentally override Stylix options.

-- #395

@trueNAHO trueNAHO added the technical debt Things which should be cleaned up or improved label Sep 9, 2024
@vfosnar
Copy link
Author

vfosnar commented Sep 10, 2024

Sorry if I misunderstood but I'm not saying we should use extraConfig. Just replace the hardcoded base0D with a new parameter accent that will default to base0D but can be overriden. This shouldn't affect IFD. I'm not familiar with how options priority is handled but I don't think adding a new one would break anything.

@danth
Copy link
Owner

danth commented Sep 10, 2024

Related: #402

@vfosnar
Copy link
Author

vfosnar commented Sep 10, 2024

alright, closing this as duplicate and will continue the discussion there

@vfosnar vfosnar closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt Things which should be cleaned up or improved
Projects
None yet
Development

No branches or pull requests

3 participants