Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: lib.mkDefault by default #549

Closed
uimataso opened this issue Sep 9, 2024 · 2 comments
Closed

Feature Request: lib.mkDefault by default #549

uimataso opened this issue Sep 9, 2024 · 2 comments

Comments

@uimataso
Copy link

uimataso commented Sep 9, 2024

Hi, I have used stylix quite some time, absolute loving this project.

But recently I notice a little inconvenience. For example, if I enabled stylix config for tofi, and I want to overwrite some config, I can't just font-size = 20;, I need to font-size = lib.mkForce 20. This means I need to manually check what config are already config in stylix, and worst part to me is some config need lib.mkForce and some not, so this brings some inconsistency.

So my wish is to make all config in stylix with lib.mkDefault, which is more sense and more intuitive to me.

But that been said, I don't know if lib.mkDefault will make sense in more complicated module tho.

And again, this is a wonderful project, thanks to all your hard work!

@trueNAHO
Copy link
Collaborator

trueNAHO commented Sep 9, 2024

This has already been proposed and discussed in #388 (comment).

@uimataso
Copy link
Author

Ohhh, I have search mkDefault, but somehow didn't see it :(, I will close the this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants