-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stylix: support various stylix.fonts.sizes
units
#251
Labels
technical debt
Things which should be cleaned up or improved
Comments
trueNAHO
added a commit
to trueNAHO/stylix
that referenced
this issue
Feb 7, 2024
danth
pushed a commit
that referenced
this issue
Feb 7, 2024
* fix(modules/qutebrowser): use correct 'fonts.web.size.default' type Use the correct 'fonts.web.size.default' type to avoid the following error: > Errors occurred while reading config.py: > While setting 'fonts.web.size.default': Invalid value '10pt' - > expected a value of type int but got str. Reference: https://qutebrowser.org/doc/help/settings.html#fonts.web.size.default Follows: #221 * fix(modules/qutebrowser): convert 'point' unit to 'pixel' unit Addresses: #239 (comment) Requires: #251
This could make use of black box types, which will be introduced by #102, to allow syntax like:
See here for the library function which implements this. |
trueNAHO
added a commit
to jezcope/stylix
that referenced
this issue
Sep 11, 2024
trueNAHO
pushed a commit
to jezcope/stylix
that referenced
this issue
Sep 12, 2024
Link: danth#251 Link: danth#552 Reviewed-by: NAHO <[email protected]>
trueNAHO
pushed a commit
to jezcope/stylix
that referenced
this issue
Sep 12, 2024
Link: danth#251 Link: danth#552 Tested-by: cgahr <[email protected]> Reviewed-by: NAHO <[email protected]>
trueNAHO
pushed a commit
that referenced
this issue
Sep 20, 2024
Link: #251 Link: #552 Tested-by: cgahr <[email protected]> Reviewed-by: NAHO <[email protected]>
mateusauler
pushed a commit
to mateusauler/stylix
that referenced
this issue
Nov 17, 2024
Link: danth#251 Link: danth#552 Tested-by: cgahr <[email protected]> Reviewed-by: NAHO <[email protected]>
mateusauler
pushed a commit
to mateusauler/stylix
that referenced
this issue
Nov 20, 2024
Link: danth#251 Link: danth#552 Tested-by: cgahr <[email protected]> Reviewed-by: NAHO <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
config.stylix.fonts.sizes
attribute set should be extended to support thepixel
andpoint
units due to various applications supporting different units.Each
exact
value of thepixel
andpoint
units should have a complementaryrounded
value to account for the1 point = (4 / 3) pixels
conversion introducing floating point numbers. For reference, numbers can be efficiently rounded withnumber: builtins.floor (number + 0.5)
.To avoid inconsistencies, an assertion should verify that only one of the
pixel
andpoint
units is set by the end user.Related: #239 (comment)
The text was updated successfully, but these errors were encountered: