Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable 'pkk' line #163 gmphd.py is not used #3

Open
JohnPekl opened this issue Jan 12, 2021 · 2 comments
Open

Variable 'pkk' line #163 gmphd.py is not used #3

JohnPekl opened this issue Jan 12, 2021 · 2 comments

Comments

@JohnPekl
Copy link

Your code did not use pkk though you calculated.

pkk = [dot(eye(len(k[index])) - dot(k[index], self.h), comp.cov)

@JohnPekl
Copy link
Author

According to Table I, I think your code should change in this line #180 in gmphd.py from comp.cov to pkk[j].

image

@danstowell
Copy link
Owner

Thank you - I agree with you, that looks like an error in the implementation. Thanks for finding it!

Replacing comp.cov with pkk[j] gives me a "singular matrix error" when I run my synthetic example. I may need to dig through and remember this old code, to work out how to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants