Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/advanced search #243

Merged
merged 20 commits into from
Oct 3, 2023
Merged

Feature/advanced search #243

merged 20 commits into from
Oct 3, 2023

Conversation

Adamik10
Copy link
Contributor

Link to issue

n/a

Description

This PR introduces the advanced search stories, components, and styling.

Screenshot of the result

desktop:
image

mobile:
image

Checklist

  • My complies with our coding guidelines.
  • My code passes our static analysis suite. If not then I have added a comment explaining why this change should be exempt from the code standards and process.
  • My code passes our continuous integration process. If not then I have added a comment explaining why this change should be exempt from the code standards and process.

Additional comments or questions

n/a

Adamik10 added 13 commits August 23, 2023 11:45
@Adamik10
Add minus and plus button icons into the Icons/Collection story
60be7da
@Adamik10
Introduce multiselect dropdown with styling & story
7285bee 
As a part of this, minor changes were made to the checkbox component
so that it can receive custom styling.
@Adamik10
Add an option to have a caption in the multiselect component story
aeca291
@Adamik10
Introduce an input with dropdown component & styling
b09f15b
@Adamik10
Introduce the Advanced search story block, component & styling
c872214
@Adamik10
Move input preview into its own component out of advanced search block
e768583 
+ account for advanced search mobile styling
@Adamik10
Introduce "CQL search" - a story variant for Advanced search
a84bb89
@Adamik10
Fix accessibility in advanced search - don't use footer for sections$
b5f7223
@Adamik10
Adjust desktop padding for advanced search input-preview preview box
6691e18
@Adamik10
Make dropdown__select--inline extend text-tags typeface
b93b4eb 
In order not to change this component's height for stories that were
already using it before.
@Adamik10
Introduce dropdown__select--inline-body-font modifier class
ccd1d55 
For dropdowns with larger font than the ones used in the facet line.
@Adamik10
Add advanced search dropdown to the top header
62f8082
@Adamik10
Show search header dropdown icon in the autosuggest
2ffadb9 
...and make sure the search header dropdown menu appears on top of
autosuggest, if it is open.
@spaceo spaceo self-requested a review September 21, 2023 13:04
spaceo
spaceo requested changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the language texts should be aligned. Otherwise great work! 👍

src/stories/Blocks/advanced-search/advanced-search.scss Show resolved Hide resolved
src/stories/Library/multiselect/Multiselect.stories.tsx Show resolved Hide resolved
src/stories/Library/multiselect/Multiselect.tsx Outdated Show resolved Hide resolved
@Adamik10 Adamik10 requested a review from spaceo September 27, 2023 13:18
spaceo
spaceo approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@Adamik10 Adamik10 merged commit 521c895 into danskernesdigitalebibliotek:develop Oct 3, 2023
6 checks passed
@Adamik10 Adamik10 deleted the feature/advanced-search branch October 3, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaceo spaceo spaceo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Adamik10 @spaceo @kasperg @kasperbirch1