-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visibility settings cause warnings when compiling for Release #25
Comments
Yeah definitely re-introducing that line. Thanks for this report. |
No problem, although (just incase you didn't already mean this) to clarify: it should be re-introduced for both iphone and iphonesim :) |
Fixed in new releases for 1.59.0 and master. |
@danoli3 it's not clear to me why, but trying this new version I get the visibility warnings in Debug now, even if I do change "Symbols Hidden by Default" to Perhaps I've lead you astray with my suggestion here? |
I found this: Interesting might be related to clang++ vs clang.............weird. See if that gets rid of the warnings? After re-building |
@danoli3 I did try using I've observed that no matter what the setting for "Symbols Hidden by Default" (including making sure it's consistent in the Pods project as well) it never passes |
Yeah throw Apple a report: https://bugreport.apple.com Let me know what their engineers say. |
When compiling our app for Release I get warnings like:
I can see this occurs because "Symbols Hidden by Default" is
YES
in a Release build. A bit of Googling suggests that boost should have been compiled with-fvisibility=hidden -fvisibility-inlines-hidden
, which was the case until this commit.Would the fix be as simple as reintroducing these compilation options, or do they cause other problems?
The text was updated successfully, but these errors were encountered: