Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webservices class attendance_handler should be moved to the classes folder #782

Open
eduardokraus opened this issue Oct 24, 2024 · 1 comment

Comments

@eduardokraus
Copy link

The attendance_handler class is currently located outside the classes folder, which is not aligned with the Moodle coding guidelines. According to the guidelines, all classes should be inside the classes directory. Could this be refactored to comply with the standard directory structure?

Is there a specific reason why this class is located outside the classes folder?

@danmarsden
Copy link
Owner

I assume you mean the webservices attendance_handler class which is over 8 years old, created before many of the current rules around classes and yeah it could do with moving into a /classes/external folder at some point - feel free to help further by submitting a PR with a fix!

@danmarsden danmarsden changed the title Should the class attendance_handler be inside the classes folder? webservices class attendance_handler should be moved to the classes folder Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants