-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AEPEX #675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR. I have a few comments about coding style.
Hey @daniestevez , I have made the requested changes. Some notes:
Best, |
Thanks @git-addrian! The code looks good now. However CI is failing. The error is ModuleNotFoundError: No module named 'satellites'. Sometimes I've seen Python errors in the Can you take at look at this? If this is working fine for you locally, I can take a look too. Maybe the CI pipeline is broken and would also fail for the |
I found the problem by building locally and importing the
The problem is that this line from .adapters import PolynomialAdapter, LinearAdapter should say from ..adapters import PolynomialAdapter, LinearAdapter Can you fix this and test locally that the telemetry parser runs correctly afterwards (since there are no unit tests for it)? |
Hey @daniestevez ,
Please let me know if there are any other changes to be made! |
Good point. I didn't notice this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good now! Merging.
Per discussion here, adding gr-satellites support for the Atmospheric Effects of Precipitation through Energetic X-Rays (AEPEX) mission. The decoder created is for 70cm telemetry.