Skip to content

Commit

Permalink
fix: Fix DNSDaemonTest - remove flaky assertion (hyperledger#7701)
Browse files Browse the repository at this point in the history
* fix: Fix DNSDaemonTest - remove flaky assertion

Signed-off-by: Usman Saleem <[email protected]>

---------

Signed-off-by: Usman Saleem <[email protected]>
  • Loading branch information
usmansaleem authored Oct 1, 2024
1 parent 9c80c9b commit d081c17
Showing 1 changed file with 0 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
*/
package org.hyperledger.besu.ethereum.p2p.discovery.dns;

import static org.assertj.core.api.Assertions.assertThat;

import java.security.Security;
import java.util.concurrent.atomic.AtomicInteger;

Expand All @@ -26,7 +24,6 @@
import io.vertx.junit5.VertxExtension;
import io.vertx.junit5.VertxTestContext;
import org.bouncycastle.jce.provider.BouncyCastleProvider;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.DisplayName;
Expand Down Expand Up @@ -136,10 +133,4 @@ void testDNSDaemonPeriodic(final Vertx vertx, final VertxTestContext testContext
.setWorkerPoolSize(1);
vertx.deployVerticle(dnsDaemon, options);
}

@AfterEach
@DisplayName("Check that the vertx worker verticle is still there")
void lastChecks(final Vertx vertx) {
assertThat(vertx.deploymentIDs()).isNotEmpty().hasSize(2);
}
}

0 comments on commit d081c17

Please sign in to comment.