Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn it into Ruby gem? #80

Closed
szymon-przybyl opened this issue Jul 10, 2013 · 4 comments · May be fixed by #84
Closed

Turn it into Ruby gem? #80

szymon-przybyl opened this issue Jul 10, 2013 · 4 comments · May be fixed by #84
Labels
duplicate An issue which duplicates an existing issue enhancement A feature request

Comments

@szymon-przybyl
Copy link

Any plans to turn this great plugin into Ruby gem? So that people using Rails would only add gem, and add "= require bootstrap-combobox" in application.js (and the same in application.css).

I can take care of this if you also think this is a good idea :)
@danielfarrell
Copy link
Owner

I hadn't thought about it. If it's desired I would not be against it. I guess the biggest question would be about how you depend on bootstrap since there are a couple of different bootstrap gems. Want to make a pull request with a gemspec?

denishaskin added a commit to constantorbit/bootstrap-combobox that referenced this issue Jul 22, 2013
@denishaskin
Make publishable as a gem. danielfarrell#80.
406cf9c
@denishaskin denishaskin mentioned this issue Jul 22, 2013
Open
@denishaskin
Copy link

Hmm. DId I do this right? Relationship of pull requests & issues sometimes confuses me.

@szymon-przybyl
Copy link
Author

Great job @denishaskin !

@thephw
Copy link
Collaborator

thephw commented May 13, 2014

This is a duplicate of #84 as well. This will likely be repackaged as a gem, but in another repo as to keep this source code cleaner. This issue will be further tracked on issue #84 toward progress toward that.

@thephw thephw closed this as completed May 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate An issue which duplicates an existing issue enhancement A feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make publishable as a gem. #80 constantorbit/bootstrap-combobox
4 participants
@danielfarrell @szymon-przybyl @denishaskin @thephw