Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit_link in gitlab also with */commit/* #19

Open
daqingshu opened this issue Aug 5, 2019 · 3 comments
Open

commit_link in gitlab also with */commit/* #19

daqingshu opened this issue Aug 5, 2019 · 3 comments

Comments

@daqingshu
Copy link

daqingshu commented Aug 5, 2019

String.contains?(url, "bitbucket.org") -> "#{url}/commits/#{sha}"

example URL https://gitlab.com/gitlab-org/gitlab-ce/commit/4b76d631e44a339f5301ed151fd8ce6af1443aa8

@danhper
Copy link
Owner

danhper commented Aug 16, 2019

Hi, thanks for reporting.
Could you open a PR with the required changes please? I will be more than happy to merge.

@daqingshu
Copy link
Author

Hi, thanks for reporting.
Could you open a PR with the required changes please? I will be more than happy to merge.

I'm a newbie, what solution do you prefer to solve this problem?

@bfontaine
Copy link
Contributor

@daqingshu I don’t know the codebase but I’d assume you can add a String.contains?(url, "gitlab.com") line like the one above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants