Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 line-numbers-*-style from feature is ignored if line numbers are enabled elsewhere #1837

Open
injust opened this issue Sep 1, 2024 · 0 comments

Comments

@injust
Copy link
Contributor

injust commented Sep 1, 2024

The Catppuccin theme used to enable line numbers for delta by default, but after discussion in catppuccin/delta#12, line numbers were disabled by default in catppuccin/delta@f294e84. The commit removed line-numbers = true in the feature, so the user could choose where to set --line-numbers themselves.

But when you run delta --line-numbers, you get non-Catppuccin line numbers.

This also happens if you add a feature for line numbers, e.g.

[delta "line-numbers"]
	line-numbers = true

and then run delta with DELTA_FEATURES=+line-numbers delta.

No matter how line numbers are enabled, it seems to override previously configured styles.

@injust injust changed the title 🐛 When --line-numbers is used, line-numbers-*-style from feature is ignored 🐛 line-numbers-*-style from feature is ignored if line numbers are enabled elsewhere Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant