Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent form styling regardless of Chosen #24

Open
nmorduch opened this issue Jul 23, 2014 · 9 comments
Open

Consistent form styling regardless of Chosen #24

nmorduch opened this issue Jul 23, 2014 · 9 comments

Comments

@nmorduch
Copy link
Contributor

Right now, selects with chosen look like they fit with bootstrap, and without chosen look like they don't fit our design. I want everything to be consistent, and maybe with a default more similar to system defaults. Like, maybe let's make selects have similar awful shading to what we're used to, but at least be the same size as everything else.

Thoughts?

@harrislapiroff
Copy link
Contributor

I think we want to achieve that consistency by making all our selects chosen. That has to be done on the python form level, but if you could make a note of places where they're wrong, that'd be helpful.

On Wed, Jul 23, 2014 at 1:52 PM, Naomi I. Morduch Toubman
[email protected] wrote:

Right now, selects with chosen look like they fit with bootstrap, and without chosen look like they don't fit our design. I want everything to be consistent, and maybe with a default more similar to system defaults. Like, maybe let's make selects have similar awful shading to what we're used to, but at least be the same size as everything else.

Thoughts?

Reply to this email directly or view it on GitHub:
#24

@nmorduch
Copy link
Contributor Author

I'm not sure all selects should be chosen. Sometimes they have three options that all start with different things and the change to the UI is not actually helpful. But you think that the lack of consistency is worse than the UI not actually being helpful?

@harrislapiroff
Copy link
Contributor

IMHO the chosen filter field is always an improvement on the default select field.

On Wed, Jul 23, 2014 at 1:58 PM, Naomi I. Morduch Toubman
[email protected] wrote:

I'm not sure all selects should be chosen. Sometimes they have three options that all start with different things and the change to the UI is not actually helpful. But you think that the lack of consistency is worse than the UI not actually being helpful?

Reply to this email directly or view it on GitHub:
#24 (comment)

@nmorduch
Copy link
Contributor Author

v. humble.

@harrislapiroff
Copy link
Contributor

But I'm not immobile on the issue.

On Wed, Jul 23, 2014 at 1:58 PM, Naomi I. Morduch Toubman
[email protected] wrote:

I'm not sure all selects should be chosen. Sometimes they have three options that all start with different things and the change to the UI is not actually helpful. But you think that the lack of consistency is worse than the UI not actually being helpful?

Reply to this email directly or view it on GitHub:
#24 (comment)

@nmorduch
Copy link
Contributor Author

Just making fun :)
I'm not either.

@melinath
Copy link
Contributor

Some selects should be radio buttons instead of Chosen

@harrislapiroff
Copy link
Contributor

🔘👍⚪️👎

⚪️👊

On Wed, Jul 23, 2014 at 3:49 PM, Stephen Burrows [email protected]
wrote:

Some selects should be radio buttons instead of Chosen

Reply to this email directly or view it on GitHub:
#24 (comment)

@nmorduch
Copy link
Contributor Author

OH YOU'RE RIGHT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants