-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Purple checkout flow that does not require iOS app #330
Comments
Notedeck rollout proposed timing / plan:
all purple subscribers should get access immediately to notedeck |
@danieldaquino to investigate in prep for notedeck launch |
Almost done and ready to go! Done:
Still in progress:
These items will probably take only a few hours Draft PRs: |
@jb55 @alltheseas, finished editing the PRs and extensively tested them:
(This took longer than expected because there were many edge cases and preconditions to be tested, and several small details to be fixed/tweaked) I recommend reviewing the server-side first, client-side second. I also highly recommend reviewing commit by commit instead of all changes at once on the website PR as many changes had to be made there. Please let me know if there are any questions or concerns. Thank you! |
@danieldaquino thanks! back now so reviewing soon |
Without going into the individual commits the only thought I have is will customers want to subscribe to notedeck using a fiat payment mechanism, and do we want to add fiat checkout prior to notedeck launch |
@jb55 to review |
moving from sprint 25 to 26 (starting oct 14 2024) |
Deployment update: Server-side changes were deployed to our staging server |
@jb55, I merged those fixes for the OTP checkout flow, and deployed to https://staging.damus.io. Please let me know if that fixes the issue you were seeing, and if it looks good for deployment at production! |
Create Purple checkout flow that does not require iOS app, so that we can provide early Notedeck access to Purple members
Suggested-by: @ vrod
The text was updated successfully, but these errors were encountered: