Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Purple checkout flow that does not require iOS app #330

Open
danieldaquino opened this issue Sep 27, 2024 · 12 comments
Open

Create Purple checkout flow that does not require iOS app #330

danieldaquino opened this issue Sep 27, 2024 · 12 comments
Assignees

Comments

@danieldaquino
Copy link

danieldaquino commented Sep 27, 2024

Create Purple checkout flow that does not require iOS app, so that we can provide early Notedeck access to Purple members

Suggested-by: @ vrod

@alltheseas
Copy link
Contributor

alltheseas commented Sep 30, 2024

Notedeck rollout proposed timing / plan:

  1. finish alpha milestone remaining tickets https://github.com/damus-io/notedeck/milestone/1
  2. internal damus team testing (can happen same time as 3))
  3. purple subscriber testing (early access is, and should be underlined as purple increased dev team access)
  4. non-purple subscriber waitlist access, testing (as long as this follows 3), it is fine; e.g. one week after 3)/after some feedback loop, iterations, and improvements per purple customer feed back)

all purple subscribers should get access immediately to notedeck

@alltheseas
Copy link
Contributor

@danieldaquino to investigate in prep for notedeck launch

@danieldaquino danieldaquino self-assigned this Sep 30, 2024
@danieldaquino
Copy link
Author

danieldaquino commented Oct 5, 2024

Almost done and ready to go!

Done:

  • Working checkout flow with OTP authentication (users can choose auth method)
  • Refactor for checkout page into manageable chunks of code
  • A nice membership welcome animation page on the web
  • A few other small fixes/improvements needed along the way.

Still in progress:

  • Some edge case testing
  • Some regression testing
  • Improve commit history and adherence to contribution guidelines.

These items will probably take only a few hours

Draft PRs:

@danieldaquino
Copy link
Author

@jb55 @alltheseas, finished editing the PRs and extensively tested them:

(This took longer than expected because there were many edge cases and preconditions to be tested, and several small details to be fixed/tweaked)

I recommend reviewing the server-side first, client-side second. I also highly recommend reviewing commit by commit instead of all changes at once on the website PR as many changes had to be made there.

Please let me know if there are any questions or concerns. Thank you!

@danieldaquino danieldaquino moved this from In Progress to In Review in Damus Roadmap 🛣️ Oct 8, 2024
@jb55
Copy link
Contributor

jb55 commented Oct 12, 2024

@danieldaquino thanks! back now so reviewing soon

@alltheseas
Copy link
Contributor

Without going into the individual commits the only thought I have is will customers want to subscribe to notedeck using a fiat payment mechanism, and do we want to add fiat checkout prior to notedeck launch

@alltheseas
Copy link
Contributor

@jb55 to review

@alltheseas
Copy link
Contributor

moving from sprint 25 to 26 (starting oct 14 2024)

@danieldaquino
Copy link
Author

Deployment update: Server-side changes were deployed to our staging server

@jb55
Copy link
Contributor

jb55 commented Oct 23, 2024

Deployment update: Server-side changes were deployed to our staging server

I tried to signup on the website on staging, but it doesn't seem to be giving me an OTP option?

Screenshot 2024-10-23 at 10 52 09

@danieldaquino
Copy link
Author

Deployment update: Server-side changes were deployed to our staging server

I tried to signup on the website on staging, but it doesn't seem to be giving me an OTP option?

Screenshot 2024-10-23 at 10 52 09

I haven't merged and deployed the client-side yet. I will do that now, please give me one moment!

@danieldaquino
Copy link
Author

@jb55, I merged those fixes for the OTP checkout flow, and deployed to https://staging.damus.io.

Please let me know if that fixes the issue you were seeing, and if it looks good for deployment at production!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

No branches or pull requests

3 participants