Render Gif and video files while composing posts #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not have time to get to this one today, but I will look into it soon! |
|
Taking a look at it now |
danieldaquino
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Thank you @scoder1747! Looks and works well, just found some minor issues. I added 2 comments to the PR.
In general, I also encourage the use of the test report in the PR template, detailing what has been covered during testing. You do that to some extent with the video, which is great and helps visualize some of the testing — but if you include some notes as to what else has been tested (e.g. edge cases, or checking if existing behaviour is not broken), this will help the reviewer save some time testing and approve your PRs faster.
Changelog-Added: Render Gif and video files while composing posts Signed-off-by: Swift Coder <[email protected]>
scoder1747
force-pushed
the
Render-Gif-and-video-files-while-composing-posts
branch
from
0897599 to
2be6015
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will introduce functionality enabling users to preview the Gif and video attachments directly within the post composition. Using this feature, users can confirm that the correct GIF or video is attached before finalizing their post, reducing errors.
Demo video showing the attachments:
r22f.mov
Demo video after PR update:
PR.Update.Video.mov
Testing performed:
Testing the video in the Post View
i. Tested Play/Pause video
ii. Tested audio
iii. Tested video icon
iv. Tested the cross button for removal
v. Testing after posting
Testing the image
i. Tested the image preview is intact (because almost no change is done on still image side)
ii. Tested the cross button for removal
iii. Testing after posting
Testing the GIF image
i. Tested the animated view
ii. Tested after GIF is posted
iii. Tested the cross button for removal
iv. Testing after posting
Also, overall flow and experience testing is also performed.
Checklist
Closes:orFixes:tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patchesTest report
Please provide a test report for the changes in this PR. You can use the template below, but feel free to modify it as needed.
Device: [Please specify the device you used for testing]
iOS: [Please specify the iOS version you used for testing]
Damus: [Please specify the Damus version or commit hash you used for testing]
Setup: [Please provide a brief description of the setup you used for testing, if applicable]
Steps: [Please provide a list of steps you took to test the changes in this PR]
Results:
Other notes
[Please provide any other information that you think is relevant to this PR.]