Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify search #2208

Open
Tracked by #2205
jb55 opened this issue May 6, 2024 · 16 comments
Open
Tracked by #2205

Unify search #2208

jb55 opened this issue May 6, 2024 · 16 comments
Assignees
Labels
design Design exploration & definition is required search

Comments

@jb55
Copy link
Collaborator

jb55 commented May 6, 2024

This is more of a design question: but does it make sense to keep global and remote search separate?

Right now we have a search box on the universe view, but it does not search the universe. It could! would could use nip50 here.

For the home timeline, search could mean only search for content from friends (suggested by @danieldaquino )

Alternatively, we could unify search into a single search box. This simplified things by having a single location for search. I like the idea of the pull-down search as seen in imessage, mail, telegram, etc.

The benefit of a unified search is that it removes lots of confusion. There is always one place to look for:

  • People/pubkeys
  • Local content
  • Remote content

For remote content, we wouldn't want to always trigger a remote search for privacy reasons, but perhaps it could be a simple "click to initiate search on relays".

I'm leaning towards removing the search box from universe and having it more like telegram:

search query
@jb55 jb55 mentioned this issue May 6, 2024
9 tasks
@jb55
Copy link
Collaborator Author

jb55 commented May 6, 2024

Open to more design ideas.

@karnagebitcoin @robagreda

@karnagebitcoin
Copy link

This is pretty much how I have it mocked up in Nostr Design (but as wireframe)

https://nostrdesign.org/docs/reference-designs/search/

@karnagebitcoin
Copy link

Could also combine all of them into one feed (limiting how many results you show), with "show more" buttons.

The benefit might be less clicking needed. You'd see some of the most relevant results right away from various categories of results, with ability to click through for more.

But I also like tabs... hard to decide.

CleanShot 2024-05-07 at 15 35 30@2x

@alltheseas
Copy link
Collaborator

@ericholguin

@alltheseas alltheseas moved this from Backlog to Planned in Damus Roadmap 🛣️ Jun 24, 2024
@robagreda
Copy link
Contributor

@jb55 @karnagebitcoin can we show by default recent search and maybe trending in the last 24hrs? similar to twitter. I am thinking that now you have to type something in order to see matching results but sometimes if just good to have something pre-filled and let me pick, if nothing there is relevant to me, I will type my query.

Tabs are usually great to separate content just in case we have a long list of matching results, I've seen that on Twitter, Instagram, Fb and more. I think is because is more scalable.

@alltheseas
Copy link
Collaborator

alltheseas commented Jun 24, 2024

default recent search

see search history #1002 - this would be great (could be local history)

maybe trending in the last 24hrs

does this require nostrdb, and then algo store #1302 #2015 @ericholguin ?

can we temporarily use nostr.band algo?

@robagreda
Copy link
Contributor

I can come up with designs for both options, tabs and something similar to what @karnagebitcoin has mocked up...

Btw, this unified search is separate than the Universe view, isn't it?

@jb55
Copy link
Collaborator Author

jb55 commented Jun 24, 2024

Could also combine all of them into one feed (limiting how many results you show), with "show more" buttons.

The benefit might be less clicking needed. You'd see some of the most relevant results right away from various categories of results, with ability to click through for more.

But I also like tabs... hard to decide.

CleanShot 2024-05-07 at 15 35 30@2x

This looks cool, maybe there could be a note result section that shows a few result highlights, and if you click it, it expands into the full result set?

@jb55
Copy link
Collaborator Author

jb55 commented Jun 24, 2024

I can come up with designs for both options, tabs and something similar to what @karnagebitcoin has mocked up...

Btw, this unified search is separate than the Universe view, isn't it?

we want to remove search from the universe view. when you go to the universe view it loads data, you shouldn't have to load data to search.

maybe the search there could be global search, I don't know. context-sensitive searching is something we want on profile pages, so maybe it makes sense on global too?

If we are going to have context-sensitive search it should only be scoped to that particular view. it doesn't make sense to have profile results on in Universe. That makes more sense in our main search box.

Instagram has a dedicated search tab at the bottom, maybe we should consider this as well.

@robagreda
Copy link
Contributor

robagreda commented Jun 24, 2024

I can come up with designs for both options, tabs and something similar to what @karnagebitcoin has mocked up...
Btw, this unified search is separate than the Universe view, isn't it?

we want to remove search from the universe view. when you go to the universe view it loads data, you shouldn't have to load data to search.

maybe the search there could be global search, I don't know. context-sensitive searching is something we want on profile pages, so maybe it makes sense on global too?

If we are going to have context-sensitive search it should only be scoped to that particular view. it doesn't make sense to have profile results on in Universe. That makes more sense in our main search box.

Instagram has a dedicated search tab at the bottom, maybe we should consider this as well.

I am thinking that we can use the search tab for a global search and a different icon to access the universe view. We can consider adding a search in universe as you've mentioned but having the global search is more than enough.

Right now we use the search tab to access the universe view alongside Search.

I remember I tried to design this in the past, but don't know if it makes sense!

image

@alltheseas
Copy link
Collaborator

alltheseas commented Jun 25, 2024

Moving to 2.0 1.10 milestone to account for design, dev investigation, and testing time

@jb55
Copy link
Collaborator Author

jb55 commented Jun 25, 2024 via email

@robagreda
Copy link
Contributor

was checking the Figma file and found that I did have a design for this!

Any thoughts?

image

@alltheseas
Copy link
Collaborator

was checking the Figma file and found that I did have a design for this!

Any thoughts?

image

👀

What I enjoy about telegram search is the vertical delineation
Top: chats and contacts
Mid: global search
Lower: messages

I wonder how might we also allow for searching only on a particular relay (and if we need to think about this today)

image

@jb55
Copy link
Collaborator Author

jb55 commented Jul 1, 2024 via email

@alltheseas
Copy link
Collaborator

alltheseas commented Jul 1, 2024

Related: MacOS search #2048
Search across sources #2081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design exploration & definition is required search
Projects
Status: Planned
Development

No branches or pull requests

5 participants