Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simp BMS Charge current scale factor #77

Open
Manny-electric opened this issue Feb 18, 2024 · 3 comments
Open

Simp BMS Charge current scale factor #77

Manny-electric opened this issue Feb 18, 2024 · 3 comments

Comments

@Manny-electric
Copy link

I am using the simp BMS option in the VCU. The BMS_ChargeLim value in the web interface seems wrong. Looking in the simpbms.cpp, the chargeCurrentLimit is divided by 1000. The simp_BMS datasheet states that this value is scaled by 10.

@7yatna
Copy link

7yatna commented Feb 18, 2024

I have noticed the same issue and didnt bother to mess with it as i really dont need this feature. but glad that you found what the issue is.

@Mitchy6
Copy link

Mitchy6 commented Oct 3, 2024

@Tom-evnut
You're likely the most active contributor. :)
Just wondering if you can roll this into an upcoming release to purge it from the issue list.

Can confirm that the scaling is currently incorrect. I've corrected it in my offline build on the bench.
If not, I'll submit a PR whenever I get my build up to date with the list of recent fixes.

@Tom-evnut
Copy link
Contributor

@Mitchy6 Please provide corrective lines of code and I can push this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants