Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use with BaseCommand #5

Closed
jayvdb opened this issue Aug 7, 2020 · 2 comments
Closed

Allow use with BaseCommand #5

jayvdb opened this issue Aug 7, 2020 · 2 comments

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Aug 7, 2020

It would be nice to allow use with normal django commands.

https://github.com/willandskill/django-executor allows this, extracting the args & options from the arg parser. See my PR there.
jayvdb added a commit to jayvdb/django-admintool-command that referenced this issue Aug 7, 2020
@jayvdb
get_command_instance: Support BaseCommand
c97e058 
Allow use with normal un-enhanced commands,
albeit without any support for args.

Related to daadu#5
@jayvdb
Copy link
Contributor Author

jayvdb commented Aug 7, 2020

PR #6 only allows use with BaseCommand, it doesnt extract the args and options.

Also note even with that, it is incompatible with django-click due to GaretJax/django-click#10

@daadu
Copy link
Owner

daadu commented Aug 16, 2020

#6 PR has landed on v0.1.1. Hence, closing this issue.

@daadu daadu closed this as completed Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayvdb @daadu