Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly name copied Position in Plate.from_positions #256

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ieivanov
Copy link
Contributor

Plate.from_positions takes

positions : dict[str, Position]
    Dictionary where keys are destination path names ('row/column/fov')
    and values are :py:class:`iohub.ngff.Position` objects.

In this PR, I'm updating the name of the copied FOV in the omero metadata to its new name: fov

@ieivanov ieivanov requested a review from ziw-liu October 12, 2024 22:15
Copy link
Collaborator

@ziw-liu ziw-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you add a regression test for this fix?

@ieivanov
Copy link
Contributor Author

I think it will be best to add this in the test_combine_fovs_to_hcs test, which we currently skip - see #255. I think it has something to do with the external ome_zarr Reader but I couldn't quite figure it out. Would you be able to fix #255 or would you suggest I add the tests elsewhere?

@ziw-liu
Copy link
Collaborator

ziw-liu commented Oct 15, 2024

I think it will be best to add this in the test_combine_fovs_to_hcs test, which we currently skip - see #255. I think it has something to do with the external ome_zarr Reader but I couldn't quite figure it out. Would you be able to fix #255 or would you suggest I add the tests elsewhere?

That test needs to be fixed (actually should be fixed before merging the original PR without skipping, not introducing a regression blocking other PRs like this). I'll see if I can do it.

@ieivanov
Copy link
Contributor Author

@ziw-liu have you had a chance to check why the ome_zarr Reader fails here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants