Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-10802: Support regopolicy instance API (OOTB policies) #345

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

ENG-10802: Support regopolicy instance API (OOTB policies) #345

wants to merge 3 commits into from
+619 −0

Conversation

gabfelp
Copy link
Contributor

@gabfelp gabfelp commented Jan 27, 2023 •
edited
Loading

Description of the change

We need to create a new resource, data_source, model and the respective tests for regopolicies-instances in terraform.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

Description of testing

@gabfelp gabfelp requested a review from Yowgf January 27, 2023 01:23
ptcar2009
ptcar2009 suggested changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@ptcar2009 ptcar2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes regarding the golang itself

cyral/model_regopolicy_instance.go Outdated Show resolved Hide resolved
cyral/model_regopolicy_instance.go Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
17.5% 17.5% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptcar2009 ptcar2009 ptcar2009 requested changes

@Yowgf Yowgf Awaiting requested review from Yowgf

@cyral-bot cyral-bot Awaiting requested review from cyral-bot cyral-bot will be requested when the pull request is marked ready for review cyral-bot is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabfelp @ptcar2009