Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Chrome for testing - version not parsed correctly #28123

Open
jannesep opened this issue Oct 24, 2023 · 4 comments · May be fixed by #28243
Open

Google Chrome for testing - version not parsed correctly #28123

jannesep opened this issue Oct 24, 2023 · 4 comments · May be fixed by #28243
Labels
prevent-stale mark an issue so it is ignored by stale[bot] type: bug

Comments

@jannesep
Copy link

Current behavior

When using Google Chrome for testing, Cypress cannot parse the browser version correctly:

bash-5.1$ chrome --version
Google Chrome for Testing 118.0.5993.70

browser: { name: 'chrome', family: 'chromium', channel: 'stable', displayName: 'Chrome', version: 'for', path: 'chrome', minSupportedVersion: 64, majorVersion: 'for', isHeadless: true, isHeaded: false }

Desired behavior

Cypress should add "Google Chrome for Testing" for the browser detection.

Test code to reproduce

Not applicable

Cypress Version

13.3.2

Node version

18.18.2

Operating System

Red Hat Enterprise Linux release 9.2 (Plow)

Debug Logs

No response

Other

No response

@jennifer-shehane
Copy link
Member

Oh, that is not great. Open to a PR to fix this.

@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label May 15, 2024
@MikeMcC399
Copy link
Contributor

MikeMcC399 commented May 15, 2024

Not yet resolved. On Ubuntu 22.04.4 browser is identified as

"Custom Chrome for"

and fails to complete a run.

The browser never connected. Something is wrong. The tests cannot run. Aborting...

https://on.cypress.io/chromium-downloads > https://www.chromium.org/getting-involved/download-chromium/
Follow instructions to download
Download the latest available Chrome for Testing binary corresponding to the Stable channel.
npx @puppeteer/browsers install chrome@stable

Browser is installed in current directory e.g. under sub-directory:

chrome/linux-124.0.6367.207/chrome-linux64/chrome

npx cypress run --e2e --browser chrome/linux-124.0.6367.207/chrome-linux64/chrome

====================================================================================================

(Run Starting)

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Cypress: 13.9.0 │
│ Browser: Custom Chrome for (headless) │
│ Node Version: v20.13.1 (/home/mike/n/bin/node) │
│ Specs: 1 found (spec.cy.js) │
│ Searched: cypress/e2e/**/*.cy.{js,jsx,ts,tsx} │
└────────────────────────────────────────────────────────────────────────────────────────────────┘

@cypress-app-bot cypress-app-bot removed the stale no activity on this issue for a long period label May 16, 2024
@jennifer-shehane jennifer-shehane added the prevent-stale mark an issue so it is ignored by stale[bot] label May 21, 2024
@jennifer-shehane jennifer-shehane removed the good first issue Good for newcomers label Jul 21, 2024
@MikeMcC399
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prevent-stale mark an issue so it is ignored by stale[bot] type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants