Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor & implement lineWidth #60

Closed
wants to merge 7 commits into from
Closed

Refactor & implement lineWidth #60

wants to merge 7 commits into from

Conversation

cyntler
Copy link
Owner

@cyntler cyntler commented Oct 18, 2022

Closes #28

  • add .nvmrc files with Node v16
  • move hamburger components to src/components
  • add new prop lineWidth
  • install & config Prettier for the project

@cyntler cyntler changed the title Refactor & implement lineHeight Refactor & implement lineWidth Oct 19, 2022
@luukdv
Copy link
Collaborator

luukdv commented Oct 19, 2022

Thanks so much for the effort! I didn't know you had this planned… I've actually been working on version 3.0 that's quite an overhaul, which should solve other use cases as well (for example being able to control both barWidth and barHeight as described in #28).

@cyntler
Copy link
Owner Author

cyntler commented Oct 19, 2022

@luukdv Oh, okay! :) I understand. So in this situation I think we can close the pull request. I will wait for you changes! :)

@cyntler cyntler closed this Oct 19, 2022
@NeeshSamsi
Copy link

@luukdv Is there any progress on the 3.0? Would love to have the lineWidth prop added at some point. This is by far the best library I've found for effortless hamburger menus.

@luukdv
Copy link
Collaborator

luukdv commented Jun 27, 2023

Thank you! Update about v3.0: Looking for new owner

@cyntler cyntler deleted the line-width branch June 27, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prop to set line-width
3 participants