Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use plain data frames instead of tibbles #1980

Open
krlmlr opened this issue Oct 7, 2023 · 1 comment
Open

Use plain data frames instead of tibbles #1980

krlmlr opened this issue Oct 7, 2023 · 1 comment
Milestone
upkeep

Comments

@krlmlr
Copy link
Collaborator

krlmlr commented Oct 7, 2023

Running dm() takes 13ms.

  • Use vctrs::data_frame() for sanity, perhaps with a "tbl" class for printing
  • Prefer vec_slice() over subsetting where possible
@krlmlr krlmlr added this to the upkeep milestone Oct 7, 2023
@krlmlr
Copy link
Collaborator Author

krlmlr commented Oct 30, 2023

dm() is now faster, the original issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
upkeep
Development

No branches or pull requests
1 participant
@krlmlr