From dc449492c5d0fda2a3d802ff6ae42e59ceb136e4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kirill=20M=C3=BCller?= <kirill@cynkra.com>
Date: Mon, 30 Oct 2023 19:58:08 +0100
Subject: [PATCH] Cleanup

---
 tests/testthat/test-duckdb.R   | 3 ---
 tests/testthat/test-maria.R    | 3 ---
 tests/testthat/test-mssql.R    | 3 ---
 tests/testthat/test-mysql.R    | 3 ---
 tests/testthat/test-postgres.R | 3 ---
 tests/testthat/test-sqlite.R   | 3 ---
 6 files changed, 18 deletions(-)

diff --git a/tests/testthat/test-duckdb.R b/tests/testthat/test-duckdb.R
index 48dee7e9bc..485977e612 100644
--- a/tests/testthat/test-duckdb.R
+++ b/tests/testthat/test-duckdb.R
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
   # Need skip in every test block, unfortunately
   skip_if_src_not("duckdb")
 
-  # https://github.com/tidyverse/dbplyr/pull/1190
-  skip_if(is(my_test_con(), "MySQLConnection"))
-
   expect_snapshot({
     dm_for_filter_df() %>%
       dm_sql(my_test_con())
diff --git a/tests/testthat/test-maria.R b/tests/testthat/test-maria.R
index 13db37d47f..ad088dd593 100644
--- a/tests/testthat/test-maria.R
+++ b/tests/testthat/test-maria.R
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
   # Need skip in every test block, unfortunately
   skip_if_src_not("maria")
 
-  # https://github.com/tidyverse/dbplyr/pull/1190
-  skip_if(is(my_test_con(), "MySQLConnection"))
-
   expect_snapshot({
     dm_for_filter_df() %>%
       dm_sql(my_test_con())
diff --git a/tests/testthat/test-mssql.R b/tests/testthat/test-mssql.R
index fe73fd2e0b..324d0f384c 100644
--- a/tests/testthat/test-mssql.R
+++ b/tests/testthat/test-mssql.R
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
   # Need skip in every test block, unfortunately
   skip_if_src_not("mssql")
 
-  # https://github.com/tidyverse/dbplyr/pull/1190
-  skip_if(is(my_test_con(), "MySQLConnection"))
-
   expect_snapshot({
     dm_for_filter_df() %>%
       dm_sql(my_test_con())
diff --git a/tests/testthat/test-mysql.R b/tests/testthat/test-mysql.R
index 92b457d48a..f0afa8a41c 100644
--- a/tests/testthat/test-mysql.R
+++ b/tests/testthat/test-mysql.R
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
   # Need skip in every test block, unfortunately
   skip_if_src_not("mysql")
 
-  # https://github.com/tidyverse/dbplyr/pull/1190
-  skip_if(is(my_test_con(), "MySQLConnection") && packageVersion("dbplyr") < "2.4.0")
-
   expect_snapshot({
     dm_for_filter_df() %>%
       dm_sql(my_test_con())
diff --git a/tests/testthat/test-postgres.R b/tests/testthat/test-postgres.R
index a324f3c83d..4912e935db 100644
--- a/tests/testthat/test-postgres.R
+++ b/tests/testthat/test-postgres.R
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
   # Need skip in every test block, unfortunately
   skip_if_src_not("postgres")
 
-  # https://github.com/tidyverse/dbplyr/pull/1190
-  skip_if(is(my_test_con(), "MySQLConnection"))
-
   expect_snapshot({
     dm_for_filter_df() %>%
       dm_sql(my_test_con())
diff --git a/tests/testthat/test-sqlite.R b/tests/testthat/test-sqlite.R
index 41362415ee..3db575dc2a 100644
--- a/tests/testthat/test-sqlite.R
+++ b/tests/testthat/test-sqlite.R
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
   # Need skip in every test block, unfortunately
   skip_if_src_not("sqlite")
 
-  # https://github.com/tidyverse/dbplyr/pull/1190
-  skip_if(is(my_test_con(), "MySQLConnection"))
-
   expect_snapshot({
     dm_for_filter_df() %>%
       dm_sql(my_test_con())