Removed task not removed

[wxtim]

Task removal doesn't appear to work (it does, behind the scenes).

Using this workflow:

[scheduler]
    allow implicit tasks = True

[scheduling]
    cycling mode = integer
    [[graph]]
        R1 = start => a

[runtime]
    [[root]]
        script = sleep 3

    [[start]]
        script = sleep 10000

Carried out the following operations

• Triggered a
• Wait for a to finish
• Remove a twice.

Note, that the workflow logs show that removal worked the first time, and reasonably enough, not the second time:

2024-12-10T16:55:13Z INFO - Command "remove_tasks" received. ID=93d66e22-5686-4dbd-b721-53158bb66a6f
    remove_tasks(flow=['all'], tasks=['1/a'])
2024-12-10T16:55:13Z INFO - Removed task(s): 1/a (flows=1)
2024-12-10T16:55:13Z INFO - Command "remove_tasks" actioned. ID=93d66e22-5686-4dbd-b721-53158bb66a6f
2024-12-10T16:55:18Z INFO - Command "remove_tasks" received. ID=c69a52d3-0335-4e10-93c1-b4c13bb58df0
    remove_tasks(flow=['all'], tasks=['1/a'])
2024-12-10T16:55:18Z WARNING - Task(s) not removable: 1/a
2024-12-10T16:55:18Z INFO - Command "remove_tasks" actioned. ID=c69a52d3-0335-4e10-93c1-b4c13bb58df0

I was able to force the task state to change using cylc reload. @oliver-sanders said

we are probably missing a data store call somewhere

citation

[wxtim]

Looking at the Cylc Flow end of the problem I've realized that the task is (correctly) not removed from the Data Store, only task flow numbers. This means that lack of flow number stuff in the gui at present mean that the task will remain shown.

I was, on re-examination, unable to remove the task by reloading.

Behind the scenes in the UI:

query {
  taskProxies {
    id
    flowNums
  }
}

{
  "data": {
    "taskProxies": [
      {
        "id": "~tim/remove/three/run1//1/start",
        "flowNums": "[1]"
      },
      {
        "id": "~tim/remove/three/run1//1/a",
        "flowNums": "[]"
      }
    ]
  }
}

[oliver-sanders]

Looking at the Cylc Flow end of the problem I've realized that the task is (correctly) not removed from the Data Store, only task flow numbers.

I think that is correct, cylc remove is removing the flow numbers, but the task still exists.

The plan was to display no-flow tasks differently to make this more obvious. From the proposal:

7. To clarify removal operations as well as flow logic in general, visual filtering of flows shall be supported in cylc gui and cylc tui as already planned - visual filtering #470.

[MetRonnie]

#2016