Set locale before (de)serializing data for SQLite #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12243810876Details
💛 - Coveralls |
Downstream Build Status Report - b4d8e8b - 2024-12-09 20:33:08 +0000Build
|
gonuke
reviewed
Dec 11, 2024
|
I thought we decided to store it in the DB. That being said however, I'm struggling with the implementation because the place that we need to read the locale from the DB is in the code interfacing with the DB. I'm thinking we read the locale from the environment, falling back to the C locale if not specified. This leaves us with the potential incompatibility of users writing archetypes named using non-ASCII characters. I can try to add tests for this and appropriate error handling so it gracefully fails in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes cyclus/cymetric#205.
I think there must be some inconsistency with how
libc++andlibboosthandle default locales. This PR callsss.imbue()to set the locale according to the user's environment, which seems to solve the segfault describe in cyclus/cymetric#205 (at least when I build and test on my arm Mac machine). We could hardcode this to the "C" locale if we want to make it more robust. The instance where I could see issues arising is if a user runs a sim in one environment then reads the SQLite DB in a different environment with a different locale.