-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update readme build/install instructions #6
Comments
@scopatz, we should probably tackle this too (making sure the readme is up to date) |
also, cycstub is currently still reported as forked form katyhuff/cycstub (which it was, but its the only repo in the cyclus group that is forked) |
Also I think the readme here should just be replaced with the hello world example once I finish it. In this case I am of the opinion that no docs are better that old doc. So if it comes down to it, we'll kill this file. |
Just a note, related to this issue, for when it gets tackled: Usage instructions for the rename script may need to be more specific.
Re: forking, I tend to prefer not erasing history. I'd prefer to let it be as-is unless it's causing some actual difficulty. I believe it's functionally identical either way. |
I'll copy over the hello world example now. I am not sure what state you got cycstub in, but it certainly seems wrong! From a clean clone, everything seems to work: scopatz@ares ~ $ git clone cycstub/
fatal: destination path 'cycstub' already exists and is not an empty directory.
scopatz@ares ~ $ git clone https://github.com/cyclus/cycstub.git fco
Cloning into 'fco'...
remote: Counting objects: 1648, done.
remote: Compressing objects: 100% (795/795), done.
remote: Total 1648 (delta 806), reused 1648 (delta 806)
Receiving objects: 100% (1648/1648), 1.43 MiB | 560.00 KiB/s, done.
Resolving deltas: 100% (806/806), done.
Checking connectivity... done.
scopatz@ares ~ $ cd fco/
scopatz@ares ~/fco develop $ ./rename.py fco_transition_region
scopatz@ares ~/fco develop $ ls
AUTHORS.rst CMakeLists.txt README.rst cmake input install.py license.rst rename.py src
scopatz@ares ~/fco develop $ ls src
CMakeLists.txt fco_transition_region_facility_tests.cc fco_transition_region_inst_tests.cc fco_transition_region_region_tests.cc
fco_transition_region_facility.cc fco_transition_region_inst.cc fco_transition_region_region.cc fco_transition_region_unit_test_driver.cc
fco_transition_region_facility.h fco_transition_region_inst.h fco_transition_region_region.h
Well, this is more about ownership and less about (git) history since no history would be destroyed. Currently, it seems weird that the root owner for cyclus and cycamore is the cyclus organization, but for cycstub it is in your userspace. I don't think that this is a big deal but would be nice to change. |
I have the right cycstub. I just called it with "python rename.py" rather than "./rename.py". |
Actually, nope, still fails. |
and, it still fails with 037cee9:
|
It looks like our cycstub 1.0.0 tag is not on the most recent cycstub On Sat, May 31, 2014 at 4:53 PM, Katy Huff [email protected] wrote:
|
What hash should 1.0.0 be on? - I can update it. |
Ah, so, the first failed run of rename.py deleted my CMakeLists.txt. So, there you go. Better now. |
Great!
The current develop head is probably best if for no other reason than the readme is updated. Thanks @rwcarlsen! |
I've done this exercise for cyclopts, cyclus, and cycamore. This readme is a bit more involved, so I'll let someone else take a crack at it.
The text was updated successfully, but these errors were encountered: