Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement necoperf-daemon #6

Merged
merged 9 commits into from
Oct 2, 2023
Merged

Implement necoperf-daemon #6

merged 9 commits into from
Oct 2, 2023

Conversation

zeroalphat
Copy link
Contributor

No description provided.

@zeroalphat zeroalphat force-pushed the add-necoperf-daemon branch 2 times, most recently from 619922c to bee2880 Compare September 21, 2023 09:09
@zeroalphat zeroalphat self-assigned this Sep 21, 2023
@zeroalphat
Implement necoperf-daemon
794bd9f 
Signed-off-by: zeroalphat <[email protected]>
@zeroalphat zeroalphat marked this pull request as ready for review September 22, 2023 05:48
zoetrope
zoetrope reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@zoetrope zoetrope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer internal to pkg.
https://go.dev/doc/modules/layout

zoetrope
zoetrope reviewed Sep 22, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
zoetrope
zoetrope reviewed Sep 22, 2023
View reviewed changes
pkg/daemon/api.go Outdated Show resolved Hide resolved
zoetrope
zoetrope reviewed Sep 22, 2023
View reviewed changes
pkg/resource/perf.go Outdated Show resolved Hide resolved
zoetrope
zoetrope approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@zoetrope zoetrope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeroalphat zeroalphat merged commit 2da88b6 into main Oct 2, 2023
3 checks passed
@zeroalphat zeroalphat deleted the add-necoperf-daemon branch October 2, 2023 06:06
@zeroalphat zeroalphat added the enhancement New feature or request label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoetrope zoetrope zoetrope approved these changes

Assignees

@zeroalphat zeroalphat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeroalphat @zoetrope