Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmn 1250 add joins #127

Merged
merged 10 commits into from
Aug 21, 2024
Merged

Cmn 1250 add joins #127

merged 10 commits into from
Aug 21, 2024

Conversation

if-loop69420
Copy link
Contributor

Summary

Add all kinds of join i could find in the oracle docs and the various clauses needed for them to be implemented

What's been done?

  • Add Inner, Outer, Natural, Cross, Cross-Apply and outer Apply joins
  • Add various tokens and SyntaxKinds
  • Write all tests needed

Me to the Joins:
grafik

KieranKaelin
KieranKaelin requested changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@KieranKaelin KieranKaelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add one test joining two times, just so we know the loop works as expected.

src/grammar/query.rs Outdated Show resolved Hide resolved
KieranKaelin
KieranKaelin requested changes Aug 21, 2024
View reviewed changes
src/grammar/query.rs Outdated Show resolved Hide resolved
src/grammar/query.rs Outdated Show resolved Hide resolved
KieranKaelin
KieranKaelin reviewed Aug 21, 2024
View reviewed changes
src/grammar/query.rs Outdated Show resolved Hide resolved
KieranKaelin
KieranKaelin reviewed Aug 21, 2024
View reviewed changes
src/grammar/query.rs Outdated Show resolved Hide resolved
@if-loop69420 @KieranKaelin
Update src/grammar/query.rs
37f9bf3 
Co-authored-by: Kieran Kaelin <[email protected]>
@KieranKaelin KieranKaelin merged commit 0bdab8f into main Aug 21, 2024
5 checks passed
@KieranKaelin KieranKaelin deleted the CMN-1250-add-joins branch August 21, 2024 09:09
if-loop69420 added a commit that referenced this pull request Aug 21, 2024
@if-loop69420 @KieranKaelin
CMN-1250: As Debora I want to be able to parse joins (#127)
ab0524b 
Co-authored-by: Kieran Kaelin <[email protected]>
if-loop69420 added a commit that referenced this pull request Aug 21, 2024
@if-loop69420
Revert "CMN-1250: As Debora I want to be able to parse joins (#127)"
a2c468e 
This reverts commit ab0524b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KieranKaelin KieranKaelin KieranKaelin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@if-loop69420 @KieranKaelin