Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visually distinguish open from closed tabs #155

Open
cxw42 opened this issue Oct 19, 2018 · 7 comments
Open

Visually distinguish open from closed tabs #155

cxw42 opened this issue Oct 19, 2018 · 7 comments
Labels
bug formerly-blocked-by-35 Issues formerly blocked on #35 poll Please respond!

Comments

@cxw42
Copy link
Owner

cxw42 commented Oct 19, 2018

Several related issues. Also related to #35.

  • Dark theme: partially-open windows have the same color text for hovered closed tabs as for open tabs. I changed the background color in 31a8e9e, which helps, but maybe there's a better way.
  • Light theme: The fix in 31a8e9e doesn't help very much - closed tabs and open tabs look the same regardless of whether they are hovered! Reported by @philiprhoades in #123 (comment).

What is the best way to show open/closed status of tabs? It needs to work whether or not they are hovered, and whether or not the TF window is focused.

@philiprhoades
Copy link

My first preference would be to have unopened tabs in grey text for both light and dark themes so you don't need hovering at all. My second preference would be to have a permanent blue background for open tabs without hovering.

cxw42 pushed a commit that referenced this issue Oct 25, 2018
@cxw42
Copy link
Owner Author

cxw42 commented Oct 25, 2018

@philiprhoades Gray text is now implemented on the switchover branch, and attached. Unzip this right over the top of your existing tfswitch tree, and reload the extension from chrome:extensions. Let me know what you think!

If you want to change the color, edit line 116 of win/main-pre.css and reload the extension to apply your changes.

webstore-0.2.0-pre.4.zip

@philiprhoades
Copy link

Sorry about the slow response - a cousin has been diagnosed with glioblastoma and my hardware hassles now appear to be exacerbated by some idiot trying on a ransom email by knowing one of my less important passwds somehow . .

Anyway, yes that change is perfect! Thanks for that.

@cxw42 cxw42 added the poll Please respond! label Oct 30, 2018
@cxw42
Copy link
Owner Author

cxw42 commented Oct 30, 2018

@philiprhoades I'm very sorry to hear about your cousin! I wish your cousin, the doctors, and your whole family all the best. That is very tough. I appreciate your thinking of me, but please do not worry about response time!

@philiprhoades
Copy link

Thanks Chris @cxw42 ,

At the beginning of the week I was here:

https://iva2018.westernsydney.edu.au

which I had been looking forward to for some time but then got an emergency case for my non-profit:

http://www.neuralarchivesfoundation.org

and had to drop everything and attend to that - so I missed the rest of the conference unfortunately. Anyway while all that was going on I found a problem with v0.2.0-pre4 but now that I have time to look at it - I can't reproduce it with a clean TF install.

Somehow what happens is that all the tabs that are in a just saved and closed window get inserted into another window when it is opened immediately after the closed window - so if I have two windows with ten tabs each, after this exercise, the second window now has 20 tabs . . this got out of control when a window with LOTS of tabs kept repeatedly getting inserted into another window - a lot single tab deletions are required to get window back to normal . .

I will keep looking at it (now that things have calmed down a little) to see if can reproduce the problem reliably . .

Phil.

@cxw42
Copy link
Owner Author

cxw42 commented Nov 9, 2018

@philiprhoades Thanks for the updates - sorry things have been so crazy! If you are able to reproduce the problem, please open a new issue.

Did this happen just after a Chrome update, by any chance? If so, it's actually a Chrome bug. See #131. The workaround is to exit Chrome and restart it. Really! :)

@philiprhoades
Copy link

@cxw42 ,

If you are able to reproduce the problem, please open a new issue.

Yes, I will keep looking into it.

Did this happen just after a Chrome update, by any chance?

No, but it might have happened with a Vivaldi update - I am mostly switched over now . . the last few weeks is a bit of a blur actually but I seem to recall an update . . Since I am still having problems with hardware (apparently) in my workstation, I have been doing most of my stuff on a lower-powered Zenbook . .

@cxw42 cxw42 added the formerly-blocked-by-35 Issues formerly blocked on #35 label Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug formerly-blocked-by-35 Issues formerly blocked on #35 poll Please respond!
Projects
None yet
Development

No branches or pull requests

2 participants