Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why are react, react-dom, styled-components dependencies, not dev and peer dependencies? #37

Open
dwjohnston opened this issue Oct 28, 2019 · 1 comment
Open

Why are react, react-dom, styled-components dependencies, not dev and peer dependencies? #37

dwjohnston opened this issue Oct 28, 2019 · 1 comment

Comments

@dwjohnston
Copy link

Given that the intention that these components should only be used by other projects, shouldn't react, etc be a peer dependency?
@ExLeonem ExLeonem mentioned this issue Jun 12, 2020
Open
@ExLeonem
Copy link

Moving react and react-dom to peerDepencies would make sense. But I think styled-components should be kept under regular dependencies, otherwise users are required to install styled-components even if they don't use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dwjohnston @ExLeonem